Alessandro/address bookmarks feedback folder logic #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…View to use same View struct
|
🚫 The Asana task linked in the PR description is not added to macOS App Board project.
|
github-actions
bot
added
the
bot: not in app board
alessandroboron
commented
Feb 19, 2024
| private extension LocalBookmarkStore { | ||
|
|
||
| @discardableResult | ||
| func update(folder: BookmarkFolder, in context: NSManagedObjectContext) throws -> BookmarkEntity { |
There was a problem hiding this comment.
This logic was already existing, I just moved into its own function so that I can use either when the folder is updated (title changes) and when the folder moves within another parent folder
alessandroboron
commented
Feb 19, 2024
| } | ||
|
|
||
| func move(entities: [BookmarkEntity], toIndex index: Int?, withinParentFolderType type: ParentFolderType, in context: NSManagedObjectContext) throws { | ||
| guard let rootFolder = bookmarksRoot(in: context) else { |
There was a problem hiding this comment.
Same as above, I just moved this existing logic in its own function so I can use it when doing an update and move in one go.
SabrinaTardio
approved these changes
Feb 20, 2024
| @@ -468,6 +468,45 @@ final class LocalBookmarkStoreTests: XCTestCase { | |||
| XCTAssertEqual(topLevelEntityIDs, [testState.initialParentFolder.id, testState.bookmark3.id]) | |||
| } | |||
|
|
|||
| func testWhenUpdatingAndMovingBookmarkFolder_ThenBookmarkFolderIsMovedAndTitleUpdated() async throws { | |||
There was a problem hiding this comment.
Is it worth testing also just moving the folder and just changing the title?
There was a problem hiding this comment.
I’ve checked and the tests weren’t there so I’ve added them (commit afeebfb)
alessandroboron
merged commit f00d684
into
alessandro/address-bookmarks-feedback
16 of 17 checks passed
alessandroboron
deleted the
alessandro/address-bookmarks-feedback-folder-logic
branch
alessandroboron
added a commit
that referenced
this pull request
Feb 27, 2024
Task/Issue URL: https://app.asana.com/0/72649045549333/1206590790808721/f **Description**: 1. Add logic and test for `AddEditBookmarkFolderViewModel`. 2. Make a common view to re-use by `AddBookmarkPopoverView` & `AddEditBookmarkDialogView` 3. Enhance `BookmarkManager` & `BookmarkStore` to update Folder title and location in one save.
alessandroboron
added a commit
that referenced
this pull request
Mar 7, 2024
Task/Issue URL: https://app.asana.com/0/72649045549333/1206590790808721/f **Description**: 1. Add logic and test for `AddEditBookmarkFolderViewModel`. 2. Make a common view to re-use by `AddBookmarkPopoverView` & `AddEditBookmarkDialogView` 3. Enhance `BookmarkManager` & `BookmarkStore` to update Folder title and location in one save.
alessandroboron
added a commit
that referenced
this pull request
Mar 7, 2024
Task/Issue URL: https://app.asana.com/0/72649045549333/1206590790808721/f **Description**: 1. Add logic and test for `AddEditBookmarkFolderViewModel`. 2. Make a common view to re-use by `AddBookmarkPopoverView` & `AddEditBookmarkDialogView` 3. Enhance `BookmarkManager` & `BookmarkStore` to update Folder title and location in one save.
alessandroboron
added a commit
that referenced
this pull request
Mar 7, 2024
Task/Issue URL: https://app.asana.com/0/72649045549333/1206590790808721/f **Description**: 1. Add logic and test for `AddEditBookmarkFolderViewModel`. 2. Make a common view to re-use by `AddBookmarkPopoverView` & `AddEditBookmarkDialogView` 3. Enhance `BookmarkManager` & `BookmarkStore` to update Folder title and location in one save.
alessandroboron
added a commit
that referenced
this pull request
Mar 14, 2024
Task/Issue URL: https://app.asana.com/0/72649045549333/1206590790808721/f **Description**: 1. Add logic and test for `AddEditBookmarkFolderViewModel`. 2. Make a common view to re-use by `AddBookmarkPopoverView` & `AddEditBookmarkDialogView` 3. Enhance `BookmarkManager` & `BookmarkStore` to update Folder title and location in one save.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1206590790808721/f
CC: @samsymons
Description:
AddEditBookmarkFolderViewModel.AddBookmarkPopoverView&AddEditBookmarkDialogViewBookmarkManager&BookmarkStoreto update Folder title and location in one save.NOTE
Number 3 Involves some refactor in the
BookmarkStore. Unit tests still pass and I’ve also added relevant ones. If it’s considered too high risk of a change I can discard last commit.Steps to test this PR:
<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the
DO NOT MERGElabel (particularly if it's a draft)If it's pending Product Review/PFR, please add the
Pending Product Reviewlabel.If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation